search

salesforce / grpc-java-contrib

Useful extensions for the grpc-java library
BSD 3-Clause "New" or "Revised" License
220 stars 34 forks source link

canteen: Pass Environment Variables #134

Closed kcy1019 closed 4 years ago

kcy1019 commented 4 years ago

Canteen currently does not pass its environment variables to java process on macOS, and it is problematic in certain case: when binary found by exec.LookPath is /usr/bin/java. On macOS, /usr/bin/java finds and executes the actual java executable by searching ${JAVA_HOME}, which is not defined in this case, hence results in error No Java runtime present, requesting install.

salesforce-cla[bot] commented 4 years ago

Thanks for the contribution! Before we can merge this, we need @kcy1019 to sign the Salesforce.com Contributor License Agreement.

rmichela commented 4 years ago

Thanks for fixing this! I'm glad you found Canteen useful.