search

salesforce / grpc-java-contrib

Useful extensions for the grpc-java library
BSD 3-Clause "New" or "Revised" License
220 stars 34 forks source link

Bump gson to 2.8.9 #171

Closed yeikel closed 2 years ago

yeikel commented 2 years ago

See https://github.com/google/gson/pull/1991

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Before we can merge this, we need @yeikel to sign the Salesforce.com Contributor License Agreement.

yeikel commented 2 years ago

image

nikolay-pshenichny commented 2 years ago

@yeikel , let me try to close/re-open the PR to see if we can get CLA re-evaluated.

yeikel commented 2 years ago

@nikolay-pshenichny Thank you for merging it

Could you please release a patch with this upgrade?

nikolay-pshenichny commented 2 years ago

@yeikel , https://github.com/salesforce/grpc-java-contrib/releases/tag/gson-v2.8.9 Thank you!

yeikel commented 2 years ago

Thank you. @nikolay-pshenichny

I was expecting to see jprotoc 1.2.1 or similar

Are you pushing that tag to maven central?

nikolay-pshenichny commented 2 years ago

@rmichela , could you please help with this ^ ?

rmichela commented 2 years ago

Released in 1.2.1 to maven central

yeikel commented 2 years ago

I am guessing it takes a while to update because I can't find it in Maven Central yet g:com.salesforce.servicelibs AND a:jprotoc AND v:1.2.1

yeikel commented 2 years ago

Unfortunately it is still not showing up

yeikel commented 2 years ago

I can see it now. Thank you!