search

salesforce / grpc-java-contrib

Useful extensions for the grpc-java library
BSD 3-Clause "New" or "Revised" License
219 stars 34 forks source link

Bump grpc + protoc versions #187

Closed ayoukhananov closed 1 year ago

ayoukhananov commented 2 years ago

I've experienced an issue trying to use the 3.19.4 version of protoc and grpc-java to being able to compile with a Custom Generator .

Using: com.google.protobuf.protoc = 3.19.4 protoc-gen-grpc-java.plugin = 1.45.1 (1.37.0 has an internal dependency on protobuf-java that does not contain com.google.protobuf.GeneratedMessageV3.isStringEmpty)

The issue : The problem is that the latest protoc generates code that depends on function (com.google.protobuf.GeneratedMessageV3.isStringEmpty) that are available from 3.17.3+.

The current issue: Since jprotoc using shade plugin to create the jar it brings protoc and protobuf code inside the jar

2. It also can solve compatibility with M1 mac : https://github.com/grpc/grpc-java/issues/8724

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Before we can merge this, we need @ayoukhananov to sign the Salesforce.com Contributor License Agreement.

rmichela commented 1 year ago

Close/reopen to re-run CI

rmichela commented 1 year ago

Superseded by #192