search

salesforce / grpc-java-contrib

Useful extensions for the grpc-java library
BSD 3-Clause "New" or "Revised" License
219 stars 34 forks source link

Remove LambdaSubscriber wrapping and use subscribe directly #61

Closed cbornet closed 6 years ago

cbornet commented 6 years ago

Or was there a reason not to use the API directly ?

salesforce-cla[bot] commented 6 years ago

Thanks for the contribution! Before we can merge this, we need @cbornet to sign the Salesforce Contributor License Agreement.

codecov[bot] commented 6 years ago

Codecov Report

Merging #61 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage     58.25%   58.25%           
  Complexity      188      188           
=========================================
  Files            40       40           
  Lines           915      915           
  Branches         67       67           
=========================================
  Hits            533      533           
  Misses          359      359           
  Partials         23       23
Impacted Files Coverage Δ Complexity Δ
...n/java/com/salesforce/rxgrpc/stub/ServerCalls.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1b4abd...8c0786b. Read the comment docs.

rmichela commented 6 years ago

Is this to make it easier to split out the reactive code?

cbornet commented 6 years ago

No. It's just to simplify the code.