search

salesforce / grpc-java-contrib

Useful extensions for the grpc-java library
BSD 3-Clause "New" or "Revised" License
220 stars 34 forks source link

Remove dangerous session implementation #78

Closed rmichela closed 6 years ago

rmichela commented 6 years ago

After talking to the gRPC team about gRPC sessions, I've realized this implementation is dangerous.

gRPC can and will transparently renegotiate transport channels. This implementation would consider each renegotiation a new session, which is absolutely incorrect.

I really hate rescinding published API, but in this case I'll make an exception due to the incorrect nature of this code. Please copy-paste the removed code into your repo if it is critical to you.

codecov[bot] commented 6 years ago

Codecov Report

Merging #78 into master will decrease coverage by 1.53%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
- Coverage     70.62%   69.09%   -1.54%     
+ Complexity      213      193      -20     
============================================
  Files            37       33       -4     
  Lines           858      783      -75     
  Branches         70       65       -5     
============================================
- Hits            606      541      -65     
+ Misses          232      224       -8     
+ Partials         20       18       -2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1bbb14f...6c9d32a. Read the comment docs.