Closed efenglu closed 5 years ago
Thanks for the contribution! Unfortunately we can't verify the commit author(s): eenglund e***@o***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.
Merging #99 into master will increase coverage by
0.05%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #99 +/- ##
============================================
+ Coverage 61.21% 61.27% +0.05%
Complexity 240 240
============================================
Files 40 40
Lines 1052 1051 -1
Branches 112 113 +1
============================================
Hits 644 644
+ Misses 384 383 -1
Partials 24 24
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...main/java/com/salesforce/jprotoc/ProtoTypeMap.java | 4.41% <0%> (+0.06%) |
1 <0> (ø) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7ccb0b7...e7cc891. Read the comment docs.
Thanks for the contribution! Before we can merge this, we need @efenglu to sign the Salesforce.com Contributor License Agreement.
It seems we were both on it at the same time. 🤣 See #100
Thank you so much for your PR! I was already in the code when you submitted your issue, so I fixed it directly before seeing the followup PR.
I'll have a release out in the next few hours.
Fixes #98