search

salesforce / helm-starter

A helm plugin for managing chart starters.
BSD 3-Clause "New" or "Revised" License
56 stars 22 forks source link

Upgrade script to use Helm v3 env variables #2

Closed myspotontheweb closed 3 years ago

myspotontheweb commented 3 years ago

Issue

Using Helm v3 the env var HELM_PATH_STARTER is no longer being set, breaking this plugin. 

$ helm version --short
v3.4.1+gc4e7485

$ helm env
HELM_BIN="helm"
HELM_CACHE_HOME="/home/mark/.cache/helm"
HELM_CONFIG_HOME="/home/mark/.config/helm"
HELM_DATA_HOME="/home/mark/.local/share/helm"
HELM_DEBUG="false"
HELM_KUBEAPISERVER=""
HELM_KUBEASGROUPS=""
HELM_KUBEASUSER=""
HELM_KUBECONTEXT=""
HELM_KUBETOKEN=""
HELM_MAX_HISTORY="10"
HELM_NAMESPACE="websites"
HELM_PLUGINS="/home/mark/.local/share/helm/plugins"
HELM_REGISTRY_CONFIG="/home/mark/.config/helm/registry.json"
HELM_REPOSITORY_CACHE="/home/mark/.cache/helm/repository"
HELM_REPOSITORY_CONFIG="/home/mark/.config/helm/repositories.yaml"

Summary of change

The FAQ describes the changes introduced by Helm V3

https://helm.sh/docs/faq/

This PR replaces the undocumented HELM_PATH_STARTER variable with $HELM_DATA_HOME/starters. Helm v2 is no longer supported, which implies this plugin has no need to be backwardly compatible (Just make it work).

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): GitOps CI g***@t***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

rmichela commented 3 years ago

Fixed elsewhere in https://github.com/salesforce/helm-starter/commit/dac9a67bd56d5c3ccb9234e88e18a8d22f8d8bdb