48 - changed IP filtering to allow for IPv6 packets - Githubissues

salesforce / ja3

JA3 is a standard for creating SSL client fingerprints in an easy to produce and shareable way.

BSD 3-Clause "New" or "Revised" License

2.61k stars 289 forks source link

48 - changed IP filtering to allow for IPv6 packets #53

Closed curob closed 3 years ago

curob commented 4 years ago

Redo of pull request 50 but now with user information set.

curob commented 4 years ago

Curious, after this gets merged in, what is the delay before the python pip packages are updated? I use ja3 in a test environment and would like to pull in the updates the "right way" as opposed to just pulling over the new source.

curob commented 4 years ago

@p-l- is there a timeline for this getting integrated and a new pip package distributed?

p-l- commented 4 years ago

@curob I do not handle this repository, sorry :)

curob commented 4 years ago

@p-l- oh, I had assumed since you approved the changes that you had the ability to merge this in (can you tell I am a gitbug novice? because I am...).

p-l- commented 4 years ago

@curob no worries! Anyone can review a PR, that was just to let you (and the repositories maintainers) that I have read your proposed patch and it looks good to me.

curob commented 4 years ago

4 weeks since pull request was approved... I ended up having to just pull the fixed code from this branch into my project instead of waiting for an "official" release. When (or if) this ever gets incorporated I will refactor accordingly.