search

salesforce / kagekiri

Shadow DOM-piercing query APIs for the browser.
BSD 3-Clause "New" or "Revised" License
86 stars 9 forks source link

feat: add support for getElementsByClassName #17

Closed tedconn closed 4 years ago

tedconn commented 4 years ago

I would like to add more support for more global deep traversing mechanisms:

tedconn commented 4 years ago

The biggest question in my mind is whether we should support live HTMLCollections or not

I mention this below/above but wouldn't that be up to whatever application is using this to introduce state? Implementing that means reimplementing an entire live DOM. kagekiri remains just a querying API? Even in Oasis we are ignoring live collections...

This PR would also need README changes for the new feature

Good call, I will make update the PR

do you intend to complete everything in the checklist in this PR?

Yes, but not in this PR, just wanted to show that that's what would be done when this PR is merged and what would be left.

nolanlawson commented 4 years ago

@tedconn Just noticed – did you mean to use classNamesLight2 and classNamesShadow2 somewhere in your tests? They're unused.

tedconn commented 4 years ago

@tedconn Just noticed – did you mean to use classNamesLight2 and classNamesShadow2 somewhere in your tests? They're unused.

good catch, I removed them in #28