We currently iterate over all enumerable properties on an object, not just own enumerable properties. This breaks anything using LBC's classSet utility, because that has enumerable props on the prototype. Anything using that helper will see add invert toString added to their class. Oops!
Does this pull request introduce a breaking change?
💔 Yes, it does introduce a breaking change.
Technically, but it's a bug fix!
Does this pull request introduce an observable change?
Details
We currently iterate over all enumerable properties on an object, not just own enumerable properties. This breaks anything using LBC's
classSet
utility, because that has enumerable props on the prototype. Anything using that helper will seeadd invert toString
added to their class. Oops!Does this pull request introduce a breaking change?
Technically, but it's a bug fix!
Does this pull request introduce an observable change?
GUS work item
W-16109991