search

salesforce / lwc

⚡️ LWC - A Blazing Fast, Enterprise-Grade Web Components Foundation
https://lwc.dev
Other
1.63k stars 395 forks source link

@W-15173926@ Upgrade LWS Babel to Release v0.22.0 #4344

Closed arcadeteddy closed 2 months ago

arcadeteddy commented 3 months ago

Details

Upgrading babel transform to fix window.top.location.

Does this pull request introduce a breaking change?

😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

Yes, window.top.location is now nested.

Before:

(window === globalThis ? top : window.top).location.href

After:

(((window === globalThis ? top : window.top) === globalThis || (window === globalThis ? top : window.top) === document) ? location : (window === globalThis ? top : window.top).location).href

GUS work item

W-15173926

salesforce-cla[bot] commented 3 months ago

Thanks for the contribution! It looks like @tlau88 is an internal user so signing the CLA is not required. However, we need to confirm this.

wjhsf commented 3 months ago

Thanks, @arcadeteddy! Can you click the button to make the CLA bot happy?

nolanlawson commented 3 months ago

Merge conflict, and the bot needs both a CLA update and a new commit to be happy ^

nolanlawson commented 2 months ago

Superseded by https://github.com/salesforce/lwc/pull/4366