search

salesforce / mirus

Mirus is a cross data-center data replication tool for Apache Kafka
BSD 3-Clause "New" or "Revised" License
203 stars 43 forks source link

Reset metrics when connector/task failed #67

Closed YongGang closed 1 year ago

YongGang commented 3 years ago

Reset metrics when connector/task failed, this is to prevent Worker reporting the last task state metrics which could be obsolete.

A better place to reset metrics is in connector/task's stop method, but in our code Herder will manage metrics reporting, so have to do it in HerderStatusMonitor

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): YongGang Che y***@s***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

codecov-io commented 3 years ago

Codecov Report

Merging #67 (feb9119) into master (03d3e45) will increase coverage by 1.48%. The diff coverage is 89.79%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
+ Coverage     56.17%   57.65%   +1.48%     
- Complexity      160      172      +12     
============================================
  Files            28       28              
  Lines          1004     1051      +47     
  Branches         73       74       +1     
============================================
+ Hits            564      606      +42     
- Misses          408      413       +5     
  Partials         32       32
Impacted Files Coverage Δ Complexity Δ
...java/com/salesforce/mirus/HerderStatusMonitor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../com/salesforce/mirus/metrics/TaskJmxReporter.java 85.29% <72.72%> (-7.81%) 10.00 <2.00> (+1.00) :arrow_down:
...salesforce/mirus/metrics/ConnectorJmxReporter.java 90.80% <100.00%> (+2.34%) 12.00 <4.00> (+3.00)
...n/java/com/salesforce/mirus/config/TaskConfig.java 100.00% <0.00%> (ø) 18.00% <0.00%> (+2.00%)
.../salesforce/mirus/config/TaskConfigDefinition.java 92.30% <0.00%> (+3.41%) 3.00% <0.00%> (ø%)
...ain/java/com/salesforce/mirus/MirusSourceTask.java 72.88% <0.00%> (+5.17%) 17.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03d3e45...feb9119. Read the comment docs.

pdavidson100 commented 3 years ago

Note that one advantage of instrumenting HerderStatusMonitor is that it will work with any connector running in the cluster without code changes — not just the open source MirusSourceConnector included in this project.