search

salesforce / offline-app-developer-starter-kit

BSD 3-Clause "New" or "Revised" License
46 stars 30 forks source link

Mobile App Plus: Offline icon missing for view action #49

Open bluebeag opened 1 year ago

bluebeag commented 1 year ago

I've created three view LWCs using the salesforce/offline-app-developer-starter-kit (github.com) and one LWC, the viewLocationRecord correctly displays the icon but Work Order and Asset are blank.

bluebeag commented 1 year ago

I found the cause of the missing icon. The Offline App Developer Starter Kit incorrectly assumes all standard icon names match the name of the object, e.g, "location" object icon is "standard:location". However, for other object like "Asset" and "WorkOrder" the icons are "asset_object" and 'work_order" respectively. I've added an optional iconName attribute to the recordHeader LWC that the parent LWC can pass to use instead of the default behavior. A pull request will need to be created for this fix.

dbreese commented 1 year ago

Nice find, @bluebeag! Feel free to submit the PR, or we can leave this issue open and we can add it in a future PR.

bluebeag commented 1 year ago

You bet! I’ll try to get a PR submitted asap. -Kevin JuddOn Jul 14, 2023, at 5:55 AM, dbreese @.***> wrote: Nice find, @bluebeag! Feel free to submit the PR, or we can leave this issue open and we can add it in a future PR.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>