search

salesforce / p4-fusion

A fast Perforce to Git conversion tool written in C++ using Perforce Helix Core C++ API and Libgit2
BSD 3-Clause "New" or "Revised" License
78 stars 15 forks source link

Add safeguards to deter people from making any changes to commit message formats #62

Open twarit-waikar opened 1 year ago

twarit-waikar commented 1 year ago
  1. Add a comment here that says the changing the commit message format is a significant change which needs to be evaluated by code owners. The blast radius of changing this format needs to be contained in a single location. https://github.com/salesforce/p4-fusion/blob/3ee482466464c18e6a635ff4f09cd75a2e1bfe0f/p4-fusion/git_api.cc#L204
  2. Add tests the try to detect if a change in the commit message format has been made and if it is a valid change.