salesforce / p4-fusion

A fast Perforce to Git conversion tool written in C++ using Perforce Helix Core C++ API and Libgit2
BSD 3-Clause "New" or "Revised" License
78 stars 15 forks source link

feat(p4_api): support older perforce servers #71

Closed ppavacic closed 8 months ago

ppavacic commented 8 months ago

This change allows use of this software with older perforce servers and clients which don't support "-r" option. See https://github.com/salesforce/p4-fusion/issues/52 for more.

salesforce-cla[bot] commented 8 months ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Paulo Pavačić p***@e***.de. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

ppavacic commented 8 months ago

Thanks for the quick reply!

Thanks for sending this! I think you also need to sign the CLA to finally merge this in.

I did, I guess im watiting now for bot to recognize that.

However I had a few comments on the PR which are really just stylistic changes, if you don't mind.

they are solved, i also didnt run clang format so we'll see how it goes.

ppavacic commented 8 months ago

@twaritwaikar hello, I was just wondering whether this merge request was forgotten. whether I should ping someone?

twarit-waikar commented 8 months ago

@ppavacic Thanks for reminding me, I just ran workflows on this PR. Looks like there are a couple formatting fixes left - https://github.com/salesforce/p4-fusion/actions/runs/7420887077/job/20381786678?pr=71

ppavacic commented 8 months ago

@ppavacic Thanks for reminding me, I just ran workflows on this PR. Looks like there are a couple formatting fixes left - https://github.com/salesforce/p4-fusion/actions/runs/7420887077/job/20381786678?pr=71

can you try now?

twarit-waikar commented 8 months ago

Thanks a ton for the work

ppavacic commented 8 months ago

that's only a small change heh

thank you for review and fast merge!