search

salesforce / p4-fusion

A fast Perforce to Git conversion tool written in C++ using Perforce Helix Core C++ API and Libgit2
BSD 3-Clause "New" or "Revised" License
78 stars 15 forks source link

Fix memory leaks #75

Closed peter-esik closed 3 months ago

peter-esik commented 6 months ago

Even though these leaks are pretty small, when using "branching mode", the one in IsInLeft accumulates quickly over time. For example, running the tool over the weekend resulted in 80+ GBs of allocated memory in my case.

On e.g. macOS, the presence of memory leaks can be checked easily: export MallocStackLogging=1;leaks --atExit -- p4-fusion [parameters];unset MallocStackLogging

salesforce-cla[bot] commented 6 months ago

Thanks for the contribution! Before we can merge this, we need @peter-esik to sign the Salesforce Inc. Contributor License Agreement.

peter-esik commented 6 months ago

Could you please sign the CLA so that we can then merge these in?

I believe so. Let me get back to you on this.

peter-esik commented 4 months ago

I need a little more time to sort things out about signing the CLA.

I'm sorry it's taking so long!

twarit-waikar commented 4 months ago

@peter-esik No issues, take your time

twarit-waikar commented 3 months ago

Thanks!