Fix leak in change_list.cc

salesforce / p4-fusion

A fast Perforce to Git conversion tool written in C++ using Perforce Helix Core C++ API and Libgit2

BSD 3-Clause "New" or "Revised" License

78 stars 15 forks source link

Closed peter-esik closed 1 month ago

peter-esik commented 2 months ago

An unfortunate regression I introduced here.

release plainly releases ownership without deleting the object, reset is the correct method to call in this case.

Sorry about the mistake, in the future I'll make sure to perform a leak check on my changes before opening a PR!

twarit-waikar commented 1 month ago

Thanks for identifying this! Slipped in my review too...