search

salesforce / proto-backwards-compat-maven-plugin

A Maven plugin for protecting against backwards incompatible changes to your gRPC .proto files.
BSD 3-Clause "New" or "Revised" License
13 stars 11 forks source link

Add support of protolock for ARM64 platform #21

Closed liusheng closed 3 years ago

liusheng commented 3 years ago

When try to build other projects depend on protolock on ARM64 server, it will raise error:

OS not supported. Unable to find a protolock binary for the classifier linux-aarch_64

This change add a protolock binary for ARM64/aarch64 platform.

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Before we can merge this, we need @liusheng to sign the Salesforce.com Contributor License Agreement.

liusheng commented 3 years ago

Hi @rmichela , Could you please help to take a look this PR ? Thank you.

liusheng commented 3 years ago

Where did you get the binary for arm64? There is no official protolock binary for that platform.

https://github.com/nilslice/protolock/releases/tag/v0.15.0

Sorry, I compiled the protolock binary on my ARM64 server, maybe need to firstly promote ARM64 release in protolock upstream ?

rmichela commented 3 years ago

maybe need to firstly promote ARM64 release in protolock upstream

Yes. That's a good idea. 😄 While I like the idea of this PR, I can't accept an opaque binary that could do literally anything. Thank you for being understanding.

liusheng commented 3 years ago

Hi @rmichela , Thanks for your reply and suggestion, I have promoted protolock upstream to published a new 1.15.1 version including ARM64 binary, see: https://github.com/nilslice/protolock/releases/tag/v0.15.1 I will update this PR replace with the new arm64 binary, please take a look again. Thank you.

rmichela commented 3 years ago

Perfect! Thank you.

liusheng commented 3 years ago

Hi @rmichela I have submitted the new protolock in https://github.com/salesforce/proto-backwards-compat-maven-plugin/pull/22 Thank you.