salesforce / pytorch-qrnn

PyTorch implementation of the Quasi-Recurrent Neural Network - up to 16 times faster than NVIDIA's cuDNN LSTM
BSD 3-Clause "New" or "Revised" License
1.26k stars 193 forks source link

modify default value of hidden_size #3

Closed gyu-don closed 6 years ago

gyu-don commented 6 years ago

hidden_size: The number of features in the hidden state h. If not specified, the input size is used.

It seems that current code has a small mistake.

salesforce-cla[bot] commented 6 years ago

Thanks for the contribution! Unfortunately we can't verify if the committer, Takumi Kato, has signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Salesforce Contributor License Agreement and this Pull Request will be revalidated.

Smerity commented 6 years ago

Thanks so much for catching this error! LGTM - merged :)