search

salesforce / reactive-grpc

Reactive stubs for gRPC
BSD 3-Clause "New" or "Revised" License
829 stars 118 forks source link

issue #292 - discard support #293

Closed bruto1 closed 1 year ago

bruto1 commented 2 years ago

please review, @rmichela

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Kirill Rodionov k***@g***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Before we can merge this, we need @bruto1 to sign the Salesforce.com Contributor License Agreement.

bruto1 commented 2 years ago

can anyone else take the time to review this, please? @scottslewis @OlegDokuka

rmichela commented 2 years ago

This looks good. Why wouldn't we implement something similar for RxJava? Is this a Reactor specific issue?

rmichela commented 2 years ago

@nikolay-pshenichny Can you please take a look?

bruto1 commented 2 years ago

I don't know first thing about RxJava, @rmichela - sry :) Would've changed both impls otherwise

bruto1 commented 2 years ago

@rmichela ?