search

salesforce / reactive-grpc

Reactive stubs for gRPC
BSD 3-Clause "New" or "Revised" License
829 stars 118 forks source link

host_javabase is deprecated #294

Open juanpmarin opened 2 years ago

juanpmarin commented 2 years ago

Since bazel 5.0 the parameter used here is deprecated:

https://github.com/salesforce/reactive-grpc/blob/071f153e61c2f8dcd1df287b51dd71cd34a39fd3/bazel/java_reactive_grpc_library.bzl#L74

Generating the following error:

Traceback (most recent call last):
    File "/home/juan/.cache/bazel/_bazel_juan/7e6e30ecb52b472e0900bbc0b820a797/external/com_salesforce_servicelibs_reactive_grpc/bazel/java_reactive_grpc_library.bzl", line 71, column 36, in _reactive_grpc_library_impl
        java_info = java_common.compile(
Error in compile: in call to compile(), parameter 'host_javabase' is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_java_common_parameters=false

The documentation suggests that it can be just dropped: image

Do you find any risk on doing this?

rmichela commented 2 years ago

I'm not sure. I'm not really a Bazel expert. If you drop this, does everything Bazel still work?