salesforce / rmux

A Redis-Multiplexer written in GO
BSD 3-Clause "New" or "Revised" License
67 stars 12 forks source link

Clearer hash ring down message when whole connection pools are down #23

Open skywalkerlw opened 5 years ago

skywalkerlw commented 5 years ago

When the error message of "Hash ring is down" comes, we don't know whether it is part outage or whole connection pools are down. This MR is used to show different messages for these two cases.

salesforce-cla[bot] commented 5 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): liang.wang l***@l***.c***.au. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

salesforce-cla[bot] commented 5 years ago

Thanks for the contribution! Before we can merge this, we need @wangbourne to sign the Salesforce.com Contributor License Agreement.

skywalkerlw commented 5 years ago

Appreciate if anyone with permission can have a look at CI. It says: SalesforceEng, and we have salesforce .