salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar
BSD 3-Clause "New" or "Revised" License
224 stars 48 forks source link

Spring Boot packaging script springboot_pkg.sh can fail silently #100

Closed khogeland closed 3 years ago

khogeland commented 3 years ago

The package script should probably set -x, because it will currently continue despite failed commands. For example, if the jar command hits the command length limit, the build will produce a broken jar without any packaged dependencies and the user won't know anything is wrong until they hit runtime classpath issues.

plaird commented 3 years ago

Good catch.