make attribute names more consistent and clear - Githubissues

salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar

BSD 3-Clause "New" or "Revised" License

224 stars 48 forks source link

make attribute names more consistent and clear #109

Closed plaird closed 3 years ago

plaird commented 3 years ago

Completes the attribute renames. The rule still honors the old names, so backwards compatibility is maintained. This is for Issue #79.

The new names show consistency in naming, based on the feature area where they apply. deps_* control dependencies, bazelrun_* control bazel run behavior, and *dupclassescheck_** control the duplicate class validator.

Renamed attributes:

exclude => deps_exclude
classpath_index => deps_index_file
use_build_dependency_order => deps_use_starlark_order
fail_on_duplicate_classes => dupeclassescheck_enable
duplicate_class_allowlist => dupeclassescheck_ignorelist
jvm_flags => bazelrun_jvm_flags
data => bazelrun_data

plaird commented 3 years ago

@simontoens can you take a quick look and see if the new naming scheme looks good to you?