Extract Spring-Boot-Version from the MANIFEST of a Spring Boot JAR

salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar

BSD 3-Clause "New" or "Revised" License

224 stars 48 forks source link

Extract Spring-Boot-Version from the MANIFEST of a Spring Boot JAR #112

Closed mcamenzind closed 3 years ago

mcamenzind commented 3 years ago

This PR addresses #111.

The Bash script write_manifest.sh extracts the from the file name of the Spring boot dependencies, which is not a reliable source. This PR extracts it from the MANIFEST of a Spring Boot dependency. This is not super reliable either, maybe we could search all dependencies for Automatic-Module-Name: spring.boot.starter... and use this?

Could this fix also be applied to a 2.0.0 branch and released as 2.0.1?

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Before we can merge this, we need @mcamenzind to sign the Salesforce.com Contributor License Agreement.

mcamenzind commented 3 years ago

@salesforce-cla, better?

plaird commented 3 years ago

@mcamenzind Thanks for the contribution. 🥇 If you can't wrangle the CLA bot let me know. You might have to push again to the PR (make a small comment edit or something).