Use jar tool from toolchain

salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar

BSD 3-Clause "New" or "Revised" License

224 stars 48 forks source link

Use jar tool from toolchain #120

Closed mcamenzind closed 3 years ago

mcamenzind commented 3 years ago

This fixes #119 and makes it sensitive to the "underscore" version of the spring boot dependency, another part missing from #111.

@plaird Sorry for the direct jar use.

plaird commented 3 years ago

Thanks @mcamenzind! Not your fault on the jar issue, that was all me. I knew better, but missed it in the review.

These changes look good. I will run this change against our large set of internal Spring Boot apps to verify (currently, our only real way to test this rule, #23) before merging.