Fix build failure if java_library has no META-INF/MANIFEST.MF

salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar

BSD 3-Clause "New" or "Revised" License

224 stars 48 forks source link

Fix build failure if java_library has no META-INF/MANIFEST.MF #131

Closed fmeum closed 3 years ago

fmeum commented 3 years ago

Fixes #130.

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Before we can merge this, we need @fmeum to sign the Salesforce.com Contributor License Agreement.

fmeum commented 3 years ago

Signing the CLA failed with an error and I can't repeat the signing flow as its shown as completed. I contacted contactoss-cla@salesforce.com about this.

fmeum commented 3 years ago

My email to contactoss-cla@salesforce.com bounced back saying that this account does not exist. What do I need to do to sign the CLA now?

plaird commented 3 years ago

@fmeum Sorry for the trouble, I am reaching out internally to see how to proceed with the CLA issue.

anish commented 3 years ago

@fmeum could you try the signing link again ?

fmeum commented 3 years ago

@anish It still says "You already signed the CLA on 2021-06-08" after logging in with GitHub and doesn't let me proceed.

anish commented 3 years ago

I fixed it manually for now @fmeum , we will investigate the issue on the backend

plaird commented 3 years ago

Thanks @fmeum for the fix. Thanks @anish for the CLA solution.