salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar
BSD 3-Clause "New" or "Revised" License
224 stars 49 forks source link

singlejar implementation #24

Closed plaird closed 4 years ago

plaird commented 4 years ago

This is a big change. This PR causes the rule to use Bazel's singlejar to package the final spring boot jar, instead of the jar command. This solves issue #19 which wants to have a hermetic output.

We have been running with this new packaging approach internally at Salesforce for 4 days and haven't seen any issues in CI or in actual deployments. If this breaks you after we merge to master, please post back asap. I decided NOT to make this feature opt-in, it is enabled for all.