When working on switching to singlejar for the final packaging step in #19 I left some tech debt there around manifest generation. We are actually now generating the manifest twice - once for the old jar packager, and once for the new singlejar packager. I was torn on whether to leave the door open to allow people to switch back to using jar to do the final packaging.
In the end, I didn't make the singlejar packager an option - it is hard wired. So we should refactor that area and make it clean.
When working on switching to singlejar for the final packaging step in #19 I left some tech debt there around manifest generation. We are actually now generating the manifest twice - once for the old jar packager, and once for the new singlejar packager. I was torn on whether to leave the door open to allow people to switch back to using jar to do the final packaging.
In the end, I didn't make the singlejar packager an option - it is hard wired. So we should refactor that area and make it clean.
jar manifest https://github.com/salesforce/bazel-springboot-rule/blob/master/tools/springboot/springboot_pkg.sh#L187
singlejar manifest https://github.com/salesforce/bazel-springboot-rule/blob/master/tools/springboot/springboot_pkg.sh#L195
Goals: