search

salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar
BSD 3-Clause "New" or "Revised" License
224 stars 48 forks source link

Use exec to spawn java -jar #90

Closed joeljeske closed 3 years ago

joeljeske commented 3 years ago

By using exec to run the java process, it allows for the java process to take over the current process and handle sent signals, such as from parent processes when spawned programatically.

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Before we can merge this, we need @joeljeske to sign the Salesforce.com Contributor License Agreement.

plaird commented 3 years ago

Thanks @joeljeske for the contribution - I like it. I created Issue #91 to document it. If you don't want to bother with the Salesforce CLA, I can close your PR and submit as myself. Let me know.

It made me think that it might be helpful to allow the user to replace the launcher script, just in case someone wants to make more substantial edits. Filed as #92

plaird commented 3 years ago

@joeljeske this ended up with a merge conflict. I stuck the change into #102. Thanks for the contribution!