salesforce / simpletod

Official repository for "SimpleTOD: A Simple Language Model for Task-Oriented Dialogue"
https://arxiv.org/abs/2005.00796
BSD 3-Clause "New" or "Revised" License
235 stars 79 forks source link

Some bugs #22

Open xmhh opened 3 years ago

xmhh commented 3 years ago

Hello, I recently read your code and found that there are some problems in several places:

  1. "lexixal" in "python preprocess_multiwoz.py lexixal" in create_dataset.sh should be "lexical";
  2. The last part of the "prepare_simpletod_data.py" code saves the data, you need to use "encoding=’utf-8’ ";
  3. In the last part of the main function in main.py, when eval the checkpoint, the save path should be a relative path, without adding "./" in train.sh, and when saving eval_results.txt later, the path is also No, he will look for it from the root directory "output/gpt", but in fact it should be "output/gpt2/checkpoint-xxx"; I hope you can check these, thanks again!
pleomax0730 commented 3 years ago

Hello, I recently read your code and found that there are some problems in several places:

  1. "lexixal" in "python preprocess_multiwoz.py lexixal" in create_dataset.sh should be "lexical";
  2. The last part of the "prepare_simpletod_data.py" code saves the data, you need to use "encoding=’utf-8’ ";
  3. In the last part of the main function in main.py, when eval the checkpoint, the save path should be a relative path, without adding "./" in train.sh, and when saving eval_results.txt later, the path is also No, he will look for it from the root directory "output/gpt", but in fact it should be "output/gpt2/checkpoint-xxx"; I hope you can check these, thanks again!

I believe they didn't upload the latest project to their repo.

failable commented 2 years ago

I believe this work has been abandoned.