search

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

Swap around code in try block #104

Closed Crim closed 6 years ago

stanlemon commented 6 years ago

@Crim the description on this is thin, what are we doing here?

Crim commented 6 years ago

I think it was just super minor code cleanup. Basically just wrapping the try/catch block around the part that could actually throw the exception, and narrowing down the caught exception to the specific type that could be thrown.

Still seems valid to me.

Crim commented 6 years ago

Merge if you agree or close er out.

stanlemon commented 6 years ago

Yup, my memory is coming back to me, I think we swallowed something on start in production that should have bubbled all the way down. Going to go ahead and merge this.