search

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

Backporting fail stream to 0.9 #107

Closed stanlemon closed 6 years ago

stanlemon commented 6 years ago

Attempts to splice #90 onto the 0.9 branch.

If we can make this work we'll cut a 0.9.3 of this for @danielsd & friends.

Crim commented 6 years ago

Should I review this PR or the other PR?

stanlemon commented 6 years ago

@Crim this one.

Crim commented 6 years ago

You got weird error msgs in your test logs:

java.io.IOException: java.net.UnknownHostException: localhost2

20:41:47.249 WARN o.a.k.c.NetworkClient [DynamicSpout:main]: Connection to node 1 could not be established. Broker may not be available.

Whats up w/ the failing test?

stanlemon commented 6 years ago

@Crim Unfortunately this was not a simple grafting of the changeset onto 0.9. That test is completely different in 0.10. We dropped Kafka from it and made a bunch of other changes. I did my best to get it to a point where it could compile, but this is basically what I need to focus on. Hoping to dig in more tomorrow.

stanlemon commented 6 years ago

@Crim build is passing now, can I get a review?