Closed stanlemon closed 6 years ago
My only concerns are on the tests where
Should be simple to verify by just adjusting one of them to not throw the expected exception and see what happens.
Good catch on those finally blocks, I think I got those all back in now and addressed the other feedback as well.
This pull request does:
This pull request does NOT:
I will open a followup PR with some of the does not items, this one has gotten too big already.