search

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

Rename DefaultRetryManager to ExponentialRetryManager #114

Closed stanlemon closed 6 years ago

stanlemon commented 6 years ago

This class name is more descriptive of the behavior of the class.

stanlemon commented 6 years ago

Heads up @mmoldavan

Crim commented 6 years ago

Kinda dislike renaming it just to rename it because it will break backwards compat, but 🤷‍♂️

stanlemon commented 6 years ago

I totally get that @Crim. 0.10 (unreleased) is a big BC break from 0.9, considering everything that changed around sidelining. I think the new name is a lot more clear as to what the class does. Furthermore, I would rather make these sort of changes before we get to a 1.0.