Closed stanlemon closed 6 years ago
@Crim I've got mixed feelings on tests for this guy. I can definitely write them, they'll just be mocks explicitly verifying internal calls and I'm not entirely sure that's beneficial. By breaking out the KeyBuilder
and the TimerManager
I feel like the actual business logic of the recorders are properly covered. What do you think?
After talking with @Crim and looking at how the metrics system feeds into graphite I'm removing the task id prefixing from the DropwizardRecorder
as it does not seem necessary.
Related to #117