Add DropwizardRecorder implementation of MetricsRecorder for use with Storm 1.2

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.

BSD 3-Clause "New" or "Revised" License

41 stars 13 forks source link

Add DropwizardRecorder implementation of MetricsRecorder for use with Storm 1.2 #119

Closed stanlemon closed 6 years ago

stanlemon commented 6 years ago

Related to #117

stanlemon commented 6 years ago

@Crim I've got mixed feelings on tests for this guy. I can definitely write them, they'll just be mocks explicitly verifying internal calls and I'm not entirely sure that's beneficial. By breaking out the KeyBuilder and the TimerManager I feel like the actual business logic of the recorders are properly covered. What do you think?

stanlemon commented 6 years ago

After talking with @Crim and looking at how the metrics system feeds into graphite I'm removing the task id prefixing from the DropwizardRecorder as it does not seem necessary.