Closed Crim closed 7 years ago
See I kind of feel like this is the wrong approach. Why don't we just make this an actual list of strings?
See updated test case, should we still be trimming the inputs when the user defines a list? My thought would be no, if they encapsulate the value in quotes, then we should use it as is. If they don't encapsulate it in quotes, then I believe yaml strips extraneous whitespace
There’s no love lost from me if we drop support for the strong version altogether. Maybe not in .9, but maybe in .10? For now I think we should consider that a deprecated format for config and add warn log so that people who use that format are encouraged to switch.
Oh and no to your question, we should not trim lists. They need to just do that correctly. Part of the rationale for a list is to get out of the business of reformatting people’s config.
Yea sounds like a plan. Will accept strings with a warning log that it's deprecated.
fix for #33
Values are now split on ',' using Gauva's split library, trimmed, and filtered for empty values.