search

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
40 stars 13 forks source link

[ISSUE-33] - trim output field values after splitting #35

Closed Crim closed 7 years ago

Crim commented 7 years ago

fix for #33

Values are now split on ',' using Gauva's split library, trimmed, and filtered for empty values.

stanlemon commented 7 years ago

See I kind of feel like this is the wrong approach. Why don't we just make this an actual list of strings?

Crim commented 7 years ago

See updated test case, should we still be trimming the inputs when the user defines a list? My thought would be no, if they encapsulate the value in quotes, then we should use it as is. If they don't encapsulate it in quotes, then I believe yaml strips extraneous whitespace

stanlemon commented 7 years ago

There’s no love lost from me if we drop support for the strong version altogether. Maybe not in .9, but maybe in .10? For now I think we should consider that a deprecated format for config and add warn log so that people who use that format are encouraged to switch.

stanlemon commented 7 years ago

Oh and no to your question, we should not trim lists. They need to just do that correctly. Part of the rationale for a list is to get out of the business of reformatting people’s config.

Crim commented 7 years ago

Yea sounds like a plan. Will accept strings with a warning log that it's deprecated.