Sideline & FilterChain Improvements

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.

BSD 3-Clause "New" or "Revised" License

40 stars 13 forks source link

Sideline & FilterChain Improvements #37

Closed stanlemon closed 6 years ago

stanlemon commented 7 years ago

Address #36 & #21.

Some refactoring to work towards #27.

Remaining Todos:

[x] Update changelog
[x] Add test coverage for serialization exceptions
[x] Add test coverage for new methods on FilterChain
[x] Spearate sideline components from FilterChain
[x] Move FilterChain back into the DynamicSpout package
[x] Add coverage for isSidelineStarted()/isSidelineStopped()

stanlemon commented 7 years ago

@Crim I just realized we tightly coupled the FilterChain to sidelines by having the SidelineRequestIdentifier be the id for a step. 🤦‍♂️ I'm thinking of adding a simple interface that requires toString() called a FilterChainStepIdentifier and a DefaultFilterChainStepIdentifier for test purposes and having SidelineRequestIdentifier implement that. What do you think?

stanlemon commented 7 years ago

@Crim I messed up, I should have never moved FilterChain out of the DynamicSpout package in the first place. I'm moving it back in here, and shifting getting away from the SidelineRequestIdentifier as a method of identifying steps. I think this PR is good to go now for review.