Closed stanlemon closed 6 years ago
@Crim I just realized we tightly coupled the FilterChain to sidelines by having the SidelineRequestIdentifier be the id for a step. 🤦♂️ I'm thinking of adding a simple interface that requires toString() called a FilterChainStepIdentifier
and a DefaultFilterChainStepIdentifier
for test purposes and having SidelineRequestIdentifier
implement that. What do you think?
@Crim I messed up, I should have never moved FilterChain
out of the DynamicSpout
package in the first place. I'm moving it back in here, and shifting getting away from the SidelineRequestIdentifier
as a method of identifying steps. I think this PR is good to go now for review.
Address #36 & #21.
Some refactoring to work towards #27.
Remaining Todos:
FilterChain
FilterChain
FilterChain
back into theDynamicSpout
package