salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
40 stars 13 forks source link

Remove unused deserializer method. #38

Closed daniel-dara closed 6 years ago

daniel-dara commented 6 years ago

Resolves https://github.com/salesforce/storm-dynamic-spout/issues/39

salesforce-cla[bot] commented 6 years ago

Thanks for the contribution! Unfortunately we can't verify if the committer, Daniel Dara, has signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Salesforce Contributor License Agreement and this Pull Request will be revalidated.

Crim commented 6 years ago

Can you update the changelog with a reference to your change?

stanlemon commented 6 years ago

@Crim before I push to maven central, I wonder if I should bump the pom to 0.9.1? Dropping that interface method is going to trickle down and break anything that implemented it (even if it was, obviously, not used).