salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
40 stars 13 forks source link

Remove unused Deserializer method: getOutputFields() #39

Closed daniel-dara closed 6 years ago

daniel-dara commented 6 years ago

It appears that Deserializer.getOutputFields() is unused and based on our internal conversation, there is consensus to remove the method.

https://github.com/salesforce/storm-dynamic-spout/blob/98c4508213f4326de3a4511a072c5bed919585ef/src/main/java/com/salesforce/storm/spout/dynamic/kafka/deserializer/Deserializer.java#L56

I have opened a PR https://github.com/salesforce/storm-dynamic-spout/pull/38 to address this issue.