salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
40 stars 13 forks source link

Slightly tweak how the metrics are calculated, condense into a single loop #50

Closed Crim closed 6 years ago

Crim commented 6 years ago

This PR slightly tweaks your metric collection loops in the following way:

stanlemon commented 6 years ago

@Crim should we drop the other currentOffset metric then?

Crim commented 6 years ago

I considered it, I think for now lets just leave it. I think we should talk at some point in which (if any) of the SpoutProgress metrics are useful. I know you hate that class and want it to die, and I'm starting to agree with you :p