search

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
40 stars 13 forks source link

retrieveSidelineRequest() should deserialize directly to SidelinePayload #54

Closed stanlemon closed 6 years ago

stanlemon commented 6 years ago

For reference see: https://github.com/salesforce/storm-dynamic-spout/pull/48/files#diff-2023ea74ef0624d2e7668f3a80d170ecR167

Now that we've switched to Gson we can deserialize direct to an entity (yey). Additionally it might make sense to add a method like CuratorHelper.readJson(String path, Class clazz) to make this even more seamless.