Closed Crim closed 6 years ago
So I think you may be onto something here Lemon.
Looking at what this class is doing, I don't see the reason why we should start a background thread, who's whole purpose is to start new VirtualSpouts. With triggers de-coupled from the spout, I feel like we can just have addVirtualSpout fire it up synchronously. This removes a fair bit of complexity (both in the multi-threaded code, and in our tests).
If we go that route and the background thread is no longer starting VirtualSpouts, that thread is now only occasionally polling for status and publishing metrics.
see #55 don't merge this one.