Call close() to ensure background threads are stopped

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.

BSD 3-Clause "New" or "Revised" License

40 stars 13 forks source link

Call close() to ensure background threads are stopped #60

Closed Crim closed 6 years ago

Crim commented 6 years ago

Noticed that after a test suite run we had a lot of extraneous threads orphaned in the background.

To find these I ended up adding code like

@AfterClass
public static void after() {
 Thread.sleep(500000); // Put a break point here, Look at the running frames in the debugger.
}

Crim commented 6 years ago

No worries I did the same with persistence manger tests previously. I think somewhere there's a zk client being left behind still (not in this test class) that I have tracked down yet