Breaking up Integration tests

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.

BSD 3-Clause "New" or "Revised" License

40 stars 13 forks source link

Closed Crim closed 6 years ago

Crim commented 6 years ago

Start to breakup the integration test DynamicSpoutTest into:

DynamicSpoutTest - Covering DynamicSpout using a stand-in MockConsumer (and no sidelining logic)
SidelineSpoutTest - Covering just the Sidelining functionality, makes use of KafkaConsumer to help validate various scenarios.
KafkaConsumerTest - Integration test covering the KafkaConsumer within DynamicSpout, covers no sidelining logic.

This moves us towards being able to do #19

Crim commented 6 years ago

@stanlemon This should be ready for review. I think you already pointed out the only real logic change. The rest is just moving tests around.

Looks like no discernible increase in test run time either => 04:28 min