Closed Crim closed 6 years ago
Start to breakup the integration test DynamicSpoutTest into:
DynamicSpoutTest - Covering DynamicSpout using a stand-in MockConsumer (and no sidelining logic)
SidelineSpoutTest - Covering just the Sidelining functionality, makes use of KafkaConsumer to help validate various scenarios.
KafkaConsumerTest - Integration test covering the KafkaConsumer within DynamicSpout, covers no sidelining logic.
This moves us towards being able to do #19
@stanlemon This should be ready for review. I think you already pointed out the only real logic change. The rest is just moving tests around.
Looks like no discernible increase in test run time either => 04:28 min
Start to breakup the integration test DynamicSpoutTest into:
DynamicSpoutTest - Covering DynamicSpout using a stand-in MockConsumer (and no sidelining logic)
SidelineSpoutTest - Covering just the Sidelining functionality, makes use of KafkaConsumer to help validate various scenarios.
KafkaConsumerTest - Integration test covering the KafkaConsumer within DynamicSpout, covers no sidelining logic.
This moves us towards being able to do #19