IMO this is related to #70 as you can tell by some of the naming weirdness.
FactoryManager doesn't have any facilities for passing arguments to a constructor, which is why it was not used to create the VirtualSpoutFactory.
I have mixed feelings about the generics in DelegateSpoutFactory, in the end if this is not done we wind up casting, so I think this is a better option honestly.
Note that right now the FilterChain is part of VirtualSpout and not of DelegateSpout, I think this is worth calling out because it is the primary reason why someone would want to directly type against VirtualSpout today. Perhaps we should reconsider this, I'm open to this - we just need to make a decision that the FilterChain is a first class citizen in the interface and that we expect implementations to utilize this.
IMO this is related to #70 as you can tell by some of the naming weirdness.
FactoryManagerdoesn't have any facilities for passing arguments to a constructor, which is why it was not used to create theVirtualSpoutFactory.I have mixed feelings about the generics in
DelegateSpoutFactory, in the end if this is not done we wind up casting, so I think this is a better option honestly.Note that right now the
FilterChainis part ofVirtualSpoutand not ofDelegateSpout, I think this is worth calling out because it is the primary reason why someone would want to directly type againstVirtualSpouttoday. Perhaps we should reconsider this, I'm open to this - we just need to make a decision that theFilterChainis a first class citizen in the interface and that we expect implementations to utilize this.