search

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
40 stars 13 forks source link

Inconsistent default config values #84

Closed daniel-dara closed 4 years ago

daniel-dara commented 6 years ago

There is a minor inconsistency in that some config values are defaulted in SpoutConfig while others are in the retry manager. In some cases values are defaulted in both which seems redundant and the values even differ in some cases.

See RETRY_MANAGER_INITIAL_DELAY_MS https://github.com/salesforce/storm-dynamic-spout/blob/master/src/main/java/com/salesforce/storm/spout/dynamic/config/SpoutConfig.java#L481 https://github.com/salesforce/storm-dynamic-spout/blob/master/src/main/java/com/salesforce/storm/spout/dynamic/retry/DefaultRetryManager.java#L58

stanlemon commented 4 years ago

I believe these are all in SpoutConfig now: https://github.com/salesforce/storm-dynamic-spout/blob/b7a71a35c812e1272cdfe9d4b42c31592dcbf42c/src/main/java/com/salesforce/storm/spout/dynamic/config/SpoutConfig.java#L188-L271

If you see any other inconsistencies, please open a new issue, thanks!