search

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

Check for nulls and log accordingly #86

Closed stanlemon closed 6 years ago

stanlemon commented 6 years ago

Add checks and skip in loop if this should happen. This most likely occurs when there's bad serialization occurring on sideline requests.

stanlemon commented 6 years ago

@Crim due to some prod issues I am going to merge this logging change and cut a release for 0.9.1.

Crim commented 6 years ago

On a somewhat related note, can we push a snapshot of 0.10.x up? I'd like to get a branch of our test "echo" topology running against it and start checking what changes are required and ensure the changelog documents it correctly

stanlemon commented 6 years ago

@Crim Snapshot pushed earlier today.

stanlemon commented 6 years ago

I am going to rebase this directly onto master. There's probably a better way of orchestrating commits between the two branches, but I'm not certain the best approach right now.