Upgrade to Kafka 0.11.0.1

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.

BSD 3-Clause "New" or "Revised" License

40 stars 13 forks source link

Upgrade to Kafka 0.11.0.1 #9

Closed stanlemon closed 6 years ago

stanlemon commented 6 years ago

Addresses #6

stanlemon commented 6 years ago

Seems like we have three options @Crim: (1) We don't seek the position after a reset to the beginning anymore. (2) We seek, but catch the exception when there are no offsets on the topic and don't store state until the first poll(). (3) We change our test so that there's always one message on the topic. Note, this doesn't solve the brand spanking new topic scenario...

I started to go down the path of (1) but in hind sight I'm thinking (2) might actually be better.

stanlemon commented 6 years ago

GitHub got in a weird state with the PR and wasn't showing the rebased commits, so I'm closing in favor of #14