search

salesforce / storm-dynamic-spout

A framework for building spouts for Apache Storm and a Kafka based spout for dynamically skipping messages to be processed later.
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

Switching test to use the in memory persistence adapters #96

Closed stanlemon closed 6 years ago

stanlemon commented 6 years ago

This is an attempt to decouple the SidelineSpoutTest from Zookeeper.

stanlemon commented 6 years ago

While digging into this I also tried swapping in the MockConsumer and that proved to be much more hairy than I thought it would be. This test is tightly coupled to KafkaRecord instances and it's just going to take some serious time to decouple them and maintain the test.

Crim commented 6 years ago

Copy/pasting my comment from the other now hidden thread.

I'm not sure that solves the issue I see. If you have multiple instances of this, they're all going to overwrite eachother because its static across the jvm.

stanlemon commented 6 years ago

Based upon your comments @Crim I am going to close this for now.